From 1de89364beb885b768b71c364938d35d8dc21506 Mon Sep 17 00:00:00 2001
From: Vusa <vusakhoza@gmail.com>
Date: Thu, 9 Jul 2026 22:35:49 +0200
Subject: [PATCH] added openwa failure notifications

---
 .../processors/workflows/handlers/GatewayPaymentHandler.java | 2 +-
 .../processors/workflows/handlers/IntegrationHandler.java    | 2 +-
 .../workflows/handlers/GatewayPaymentHandlerTest.java        | 5 ++++-
 .../workflows/handlers/IntegrationHandlerTest.java           | 3 +++
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/main/java/zw/qantra/tm/domain/services/processors/workflows/handlers/GatewayPaymentHandler.java b/src/main/java/zw/qantra/tm/domain/services/processors/workflows/handlers/GatewayPaymentHandler.java
index 4515442..841dc6c 100644
--- a/src/main/java/zw/qantra/tm/domain/services/processors/workflows/handlers/GatewayPaymentHandler.java
+++ b/src/main/java/zw/qantra/tm/domain/services/processors/workflows/handlers/GatewayPaymentHandler.java
@@ -80,7 +80,7 @@ public class GatewayPaymentHandler implements HandlerInterface {
             transactionService.save(transaction);
         }
 
-        if(transaction.getPaymentStatus().equals(Status.FAILED)) {
+        if(Status.FAILED.equals(transaction.getPaymentStatus())) {
             notificationService.sendWA(waPhone, String.format(
                     "Payment failed: Transaction: %s, Customer message: %s, System message: %s",
                     transaction.getId(), transaction.getErrorMessage(), transaction.getSystemErrorMessage()));
diff --git a/src/main/java/zw/qantra/tm/domain/services/processors/workflows/handlers/IntegrationHandler.java b/src/main/java/zw/qantra/tm/domain/services/processors/workflows/handlers/IntegrationHandler.java
index aa1345a..44420d1 100644
--- a/src/main/java/zw/qantra/tm/domain/services/processors/workflows/handlers/IntegrationHandler.java
+++ b/src/main/java/zw/qantra/tm/domain/services/processors/workflows/handlers/IntegrationHandler.java
@@ -91,7 +91,7 @@ public class IntegrationHandler implements HandlerInterface {
 
         transaction.setIntegrationStatus(transaction.getStatus());
 
-        if(!transaction.getIntegrationStatus().equals(Status.SUCCESS)) {
+        if(!Status.SUCCESS.equals(transaction.getIntegrationStatus())) {
             notificationService.sendWA(waPhone, String.format(
                     "Integration failed: Transaction %s, Customer message: %s, System message: %s",
                     transaction.getId(), transaction.getErrorMessage(), transaction.getSystemErrorMessage()));
diff --git a/src/test/java/zw/qantra/tm/domain/services/processors/workflows/handlers/GatewayPaymentHandlerTest.java b/src/test/java/zw/qantra/tm/domain/services/processors/workflows/handlers/GatewayPaymentHandlerTest.java
index 319f177..864caff 100644
--- a/src/test/java/zw/qantra/tm/domain/services/processors/workflows/handlers/GatewayPaymentHandlerTest.java
+++ b/src/test/java/zw/qantra/tm/domain/services/processors/workflows/handlers/GatewayPaymentHandlerTest.java
@@ -49,6 +49,9 @@ class GatewayPaymentHandlerTest {
     @Mock
     private TransactionProcessorInterface transactionProcessor;
 
+    @Mock
+    private NotificationService notificationService;
+
     @InjectMocks
     private GatewayPaymentHandler handler;
 
@@ -63,7 +66,7 @@ class GatewayPaymentHandlerTest {
         transaction.setType(RequestType.REQUEST);
         transaction.setAuthType(AuthType.MOBILE);
         transaction.setPaymentProcessorLabel("ecocash");
-        transaction.setPaymentStatus(null);
+        transaction.setPaymentStatus(Status.PENDING);
 
         lenient().when(transactionService.getTransactionRepository()).thenReturn(transactionRepository);
     }
diff --git a/src/test/java/zw/qantra/tm/domain/services/processors/workflows/handlers/IntegrationHandlerTest.java b/src/test/java/zw/qantra/tm/domain/services/processors/workflows/handlers/IntegrationHandlerTest.java
index cd4285b..f82eb27 100644
--- a/src/test/java/zw/qantra/tm/domain/services/processors/workflows/handlers/IntegrationHandlerTest.java
+++ b/src/test/java/zw/qantra/tm/domain/services/processors/workflows/handlers/IntegrationHandlerTest.java
@@ -48,6 +48,9 @@ class IntegrationHandlerTest {
     @Mock
     private TransactionProcessorInterface transactionProcessor;
 
+    @Mock
+    private NotificationService notificationService;
+
     @InjectMocks
     private IntegrationHandler handler;